Skip to content

Rename named-wrapper value field to unnamed#227

Merged
mtfishman merged 1 commit into
mainfrom
mf/rename-value-to-unnamed
Jul 24, 2026
Merged

Rename named-wrapper value field to unnamed#227
mtfishman merged 1 commit into
mainfrom
mf/rename-value-to-unnamed

Conversation

@mtfishman

Copy link
Copy Markdown
Member

Summary

Renames the wrapped-object field of Named, NamedArray, and NamedUnitRange from value to unnamed, so the field name matches the unnamed accessor that reads it. Also renames the internal setvalue helper to setunnamed, keeping it symmetric with the existing setname.

## Summary

Renames the wrapped-object field of `Named`, `NamedArray`, and `NamedUnitRange` from `value` to `unnamed`, so the field name matches the `unnamed` accessor that reads it. Also renames the internal `setvalue` helper to `setunnamed`, keeping it symmetric with the existing `setname`.
@mtfishman
mtfishman enabled auto-merge (squash) July 24, 2026 00:37
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.29%. Comparing base (2565e4a) to head (d410b2e).

Files with missing lines Patch % Lines
src/named.jl 28.57% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage   77.29%   77.29%           
=======================================
  Files          29       29           
  Lines        1718     1718           
=======================================
  Hits         1328     1328           
  Misses        390      390           
Flag Coverage Δ
docs 27.11% <40.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman
mtfishman merged commit 6e469b8 into main Jul 24, 2026
17 of 18 checks passed
@mtfishman
mtfishman deleted the mf/rename-value-to-unnamed branch July 24, 2026 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant